Codecov Report

Merging #1 (a41ac04) into main (56c5259) will decrease coverage by 4.54%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##              main       #1      +/-   ##
===========================================
- Coverage   100.00%   95.45%   -4.55%     
===========================================
  Files            2        3       +1     
  Lines           20       22       +2     
===========================================
+ Hits            20       21       +1     
- Misses           0        1       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c5259...a41ac04. Read the comment docs.

Coming from the reddit thread - I don't think you need to wrap tokio's RecvError, since it's only a unit error. There's no information in it, so you might as well a) have a unit error type of your own like SpawnFailed or b) just unwrap it, since if you're catching panics it shouldn't ever fail to send something through the channel.

Coming from the reddit thread - I don't think you need to wrap tokio's RecvError, since it's only a unit error. There's no information in it, so you might as well a) have a unit error type of your own like SpawnFailed or b) just unwrap it, since if you're catching panics it shouldn't ever fail to send something through the channel.

That's a great point! It could only fail if the sender is dropped, but I'm controlling the sender, so that shouldn't ever happen. I'll just have it return unconditionally then :) Thanks!

You don't have any panic tests that actually call the spawn method. They all just construct the handle directly.

Fixed!

@Darksonn @coolreader18 Thanks so much for the feedback! Super helpful :) I'm going to go ahead and merge & release. If there's anything else you notice, feel free to file an issue, and I'll take a look at it 👍